Skip to content

Fixes an issue where the default timestamp was set to 0 #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mediabounds merged 1 commit into from
Jan 11, 2023
Merged

Fixes an issue where the default timestamp was set to 0 #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Float.TinCan.ActivityLibrary.Tests/TinCanStatementBuilder.tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,16 @@ public void TestBuildStatement()
.Build();
Assert.NotNull(statement);
}

[Fact]
public void TestDefaultStatementTimestamp()
{
var statement = new TinCanStatementBuilder()
.Build();

// The default timestamp should be (approximately) now.
Assert.InRange(statement.timestamp ?? new System.DateTime(), System.DateTime.UtcNow.AddSeconds(-1), System.DateTime.UtcNow);
System.Console.WriteLine(statement.ToJSON());
}
}
}
2 changes: 1 addition & 1 deletion Float.TinCan.ActivityLibrary/TinCanStatementBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public class TinCanStatementBuilder
/// <summary>
/// The timestamp for the statement to be built. Optional.
/// </summary>
DateTime timestamp;
DateTime? timestamp;

/// <summary>
/// Gets the session ID for the statement to be build. Optional.
Expand Down