CASL part 1 #189
Open
CASL part 1 #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdresser
commented
Aug 11, 2025
tdresser
commented
Aug 11, 2025
| phoneNumber!: string; | ||
|
|
||
| @ManyToOne(() => OrganizationEntity) | ||
| @ManyToOne(() => OrganizationEntity, { joinColumn: "organizationId" }) |
Collaborator
Author
There was a problem hiding this comment.
We make sure the organizationId exists, and is the same name as the DTO property, so this can be used in CASL rules.
tdresser
commented
Aug 11, 2025
tdresser
commented
Aug 11, 2025
tdresser
commented
Aug 11, 2025
tdresser
commented
Aug 11, 2025
| }, | ||
| }); | ||
| return <div>{(users?.users ?? []).map((x) => UserRow({ user: x }))}</div>; | ||
| return <div>{users.users.map((x) => UserRow({ user: x }))}</div>; |
Collaborator
Author
There was a problem hiding this comment.
Fix an eslint warning I didn't get when landing the search fix.
Collaborator
Author
|
This is ready for review! Start here. |
tdresser
force-pushed
the
casl
branch
6 times, most recently
from
d8bcbc2 to
728a2a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements CASL authorization, but doesn't use it, or integrate it at the db level.
The framework for using it with mikroORM is landed, but only used in a test showing off roughly how it works.
Followup patches will integrate this into our repository and baseentitiy classes, and ensure this is used by our services.