build & run in Dockerfile, dev override in compose #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a step towards making our Dockerfile ready for prod while retaining a nice dev experience.
Adding the
--platform=linux/amd64is perhaps the spiciest take in here. This makes things work correctly on apple silicon (where it runs under emulation) but may not be desirable in other environments, please let me know if this breaks things for WSL or something.apt-get cleanremoves unneeded caches from the final docker image.The other changes make it so the default image built by our Dockerfile runs the app directly, but the compose.yaml used for local dev still sleeps forever allowing interactive development.
Note that the
turbo buildcommand currently doesn't work due to #271 soDONT MERGE THIS (yet)
Leaving it as a draft until this is fixed.