Skip to content

Conversation

@SenorBlanco
Copy link
Contributor

@SenorBlanco SenorBlanco commented Nov 7, 2023


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@SenorBlanco SenorBlanco requested a review from kainino0x November 7, 2023 20:30
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % build failure

@SenorBlanco SenorBlanco merged commit 2835c6b into gpuweb:main Nov 7, 2023
greggman added a commit that referenced this pull request Nov 9, 2023
greggman added a commit to greggman/cts that referenced this pull request Nov 9, 2023
greggman added a commit to greggman/cts that referenced this pull request Nov 10, 2023
greggman added a commit that referenced this pull request Nov 10, 2023
SenorBlanco added a commit that referenced this pull request Nov 12, 2023
kainino0x pushed a commit that referenced this pull request Nov 13, 2023
greggman added a commit to greggman/cts that referenced this pull request Nov 27, 2023
…de. (gpuweb#3140)" (gpuweb#3161)"

This reverts commit 0e06340.

These tests test writeBuffer, copyBufferToTexture, and copyTextureToBuffer
as it says at the top of the file. They should not have been disabled for
textures that don't support copyTextureToBuffer. For those cases they
use rendering compare results.
greggman added a commit to greggman/cts that referenced this pull request Nov 30, 2023
…de. (gpuweb#3140)" (gpuweb#3161)"

This reverts commit 0e06340.

These tests test writeBuffer, copyBufferToTexture, and copyTextureToBuffer
as it says at the top of the file. They should not have been disabled for
textures that don't support copyTextureToBuffer. For those cases they
use rendering compare results.
greggman added a commit that referenced this pull request Nov 30, 2023
…de. (#3140)" (#3161)"

This reverts commit 0e06340.

These tests test writeBuffer, copyBufferToTexture, and copyTextureToBuffer
as it says at the top of the file. They should not have been disabled for
textures that don't support copyTextureToBuffer. For those cases they
use rendering compare results.
@SenorBlanco SenorBlanco deleted the skip-compressed-copy-compat branch April 10, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants