Skip to content

Conversation

@greggman
Copy link
Contributor

@greggman greggman commented Jun 3, 2025

This pulls in new formats for feature 'texture-formats-tier1' which required updates to format_info.ts, capability_info.ts and several tests.

Note: Since no implementation actually supports 'texture-formats-tier1' yet it's very possible some tests will need fixes when the feature is implemented.

@greggman greggman requested a review from kainino0x June 3, 2025 00:16
@greggman
Copy link
Contributor Author

greggman commented Jun 3, 2025

Ran locally in dawn.node and fixed what I saw. Running here https://dawn-review.googlesource.com/c/dawn/+/245034 to test on browser.

@greggman
Copy link
Contributor Author

greggman commented Jun 3, 2025

Also, it's not clear from the spec I think, either WGSL is supposed to allow these formats by default. For example, WGSL allows texture_storage_2d<bgra8norm, ...> even if bgra8norm-storage is not available.

  • Should WGSL allow texture_storage_2d<rgba16unorm> (a format that does not exist without texture-formats-tier1)
  • Should WGSL allow texture_storage_2d<r8unorm> (a format that does exist but doesn't support storage without texture-formats-tier1

As it is, a few tests here and there currently fail with WGSL compilation errors for these formats. I feel like WGSL should allow these, same as it allows bgra8unorm

@kainino0x
Copy link
Collaborator

Agree it should work the same as bgra8unorm. AFAICT neither API nor WGSL spec calls out bgra8unorm as special, so seems like these new ones should behave the same as it.

This pulls in new formats for feature 'texture-formats-tier1'
which required updates to format_info.ts, capability_info.ts
and several tests.

Note: Since no implementation actually supports 'texture-formats-tier1'
yet it's very possible some tests will need fixes when the feature
is implemented.
@greggman greggman force-pushed the update-types-tier1 branch from 27a5e58 to ab6b326 Compare June 3, 2025 05:00
@greggman greggman enabled auto-merge (squash) June 3, 2025 05:02
@greggman greggman merged commit 75289e0 into gpuweb:main Jun 3, 2025
1 check passed
@greggman greggman deleted the update-types-tier1 branch June 3, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants