-
Notifications
You must be signed in to change notification settings - Fork 101
Alternate fix for fragment input deductions in max_variables_count,input #4555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternate fix for fragment input deductions in max_variables_count,input #4555
Conversation
|
Results for build job (at dee62c8): -webgpu:api,validation,render_pipeline,inter_stage:max_variables_count,input:* - 8 cases, 8 subcases (~1/case)
+webgpu:api,validation,render_pipeline,inter_stage:max_variables_count,input:* - 6 cases, 12 subcases (~2/case)
-TOTAL: 284500 cases, 2342678 subcases
+TOTAL: 284498 cases, 2342682 subcases |
|
DOH! Sorry, I missed that there was already a PR up for this. Choose which ever one you prefer. |
|
Oh sorry, missed that that PR had two files! |
Co-authored-by: Gregg Tavares <github@greggman.com>
|
Pulled in the extra optional-feature builtins from #4554 |
|
I removed the changes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, you'll need to add the enabled stuff to the WGSL or these will fail. Here's my previous PR for reference
Ahh whoops, thank you for catching that! Totally forgot to copy that over. (I didn't test against fixed chromium, I probably should. Seems like the fix will be in Canary very soon so I'll just wait until then and verify this.) |
I took Erich's test fix #4546, then tried to tweak the original structure of the test so it's clear by construction that it actually tests what it's supposed to test.
Issue: #4538
See also #4539.
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.