Skip to content

Conversation

@andyleiserson
Copy link
Contributor

@andyleiserson andyleiserson commented Jan 17, 2026

Changes the readonly_and_readwrite_storage_textures test to check for feature support.

Issue: none


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@github-actions
Copy link

Results for build job (at c318703):

 Test case/subcase counts did not change.


const requiredFeature = getRequiredFeatureForTextureFormat(format);
if (requiredFeature) {
t.skipIfDeviceDoesNotHaveFeature(requiredFeature);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm........ in theory, the correct thing to do here would be to check wgslLanguageFeatures and not the device features. Because:

  1. It's not just the new formats that should be skipped when the browser doesn't have support, it's also the existing formats that were newly-added to WGSL.
  2. We should be running this test if the browser (compiler) supports the format, even if the device doesn't.

But we didn't add a wgsl language feature! Filed gpuweb/gpuweb#5524


g.test('var_decl')
.desc(
`Checks that the read and read_write access modes are only allowed with the language feature present`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`Checks that the read and read_write access modes are only allowed with the language feature present
TODO(https://github.com/gpuweb/gpuweb/issues/5524): Fix this to check wgslLanguageFeatures
of the device features.
`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants