Skip to content

Conversation

@sudonatalie
Copy link
Contributor

Check that a valid mix of swizzles and index works and that an invalid OOB case fails.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@sudonatalie sudonatalie requested a review from jrprice January 20, 2026 20:09
@github-actions
Copy link

github-actions bot commented Jan 20, 2026

Results for build job (at 5aa0dd7):

-webgpu:shader,validation,expression,access,vector:concrete:* - 60 cases, 6480 subcases (~108/case)
-webgpu:shader,validation,expression,access,vector:abstract:* - 24 cases, 2592 subcases (~108/case)
+webgpu:shader,validation,expression,access,vector:concrete:* - 60 cases, 6600 subcases (~110/case)
+webgpu:shader,validation,expression,access,vector:abstract:* - 24 cases, 2640 subcases (~110/case)
-TOTAL: 285744 cases, 2344468 subcases
+TOTAL: 285744 cases, 2344636 subcases


// mixed swizzle and indexing
xy_0: { wgsl: 'const r = V.xy[0];', result_width: 1, ok: true },
xy_3: { wgsl: 'const r = V.xy[3];', ok: false },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this passes because V is not a memory view, so it's not hitting the SwizzleView case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added 2 more tests that are on variables, and confirmed that that test fails on my old patchset and passes on my new one.

Check that a valid mix of swizzles and index works and that an invalid OOB case fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants