Windows: Add support for SYMLINKS#37
Merged
adammurdoch merged 2 commits intogradle:masterfrom Jul 16, 2019
Merged
Conversation
rpaquay
force-pushed
the
add-symlink-support
branch
3 times, most recently
from
f3ec80d to
f852195
Compare
lacasseio
reviewed
May 30, 2019
| pFileStat->fileType = FILE_TYPE_FILE; | ||
| } | ||
| return ERROR_SUCCESS; | ||
| #else //WINDOWS_MIN: Windows Vista+ support for symlinks |
There was a problem hiding this comment.
I think it's safe to assume the code will be running on Windows Vista+
Contributor
Author
|
fyi: I added a commit (5c890ef) that contains unit tests (in the FilesTest.groovy file) for "stat" and "readdir" using symbolic links. Unfortunately, for these test to run on Windows, you either need to run them in an "elevated" command prompt, or with Windows 10 with developer mode enabled. This is a Windows limitation that cannot be worked around. This restriction is only for creating symbolic links, though (reading them is fine without extra privileges). |
* Both `stat` and `readdir` entry points support returning FILE_TYPE_SYMLINK * Both `stat` and `readdir` entry points support the "followLink" parameter * Add a `stat-L` option in the test app (`stat` with `followLink` option) * Add a `ls-L` option in test app (`ls` with `followLink` option) * Requires Windows Vista/Windows Server 2008 or later
* The tests only run on Windows Vista+ in an elevated command prompt, or on Windows 10+ in developer mode. * See https://blogs.windows.com/buildingapps/2016/12/02/symlinks-windows-10 for details on these restrictions.
rpaquay
force-pushed
the
add-symlink-support
branch
from
5c890ef to
d9588ba
Compare
Contributor
Author
|
Ping? Anything I can do to move this PR forward? |
Contributor
|
@rpaquay your changes look good, I'll merge them soon. Apologies for taking so long to review your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows: Add support for SYMLINKS
statandreaddirentry points support returning FILE_TYPE_SYMLINKstatandreaddirentry points support the "followLink" parameterstat-Loption in the test app (statwithfollowLinkoption)ls-Loption in test app (lswithfollowLinkoption)