Quote parameters in output log

[koppor]

Somehow refs #105

I see following in my log

--app-image /home/koppor/git-repositories/jabref/jabgui/build/packages/ubuntu-22.04/JabRef --description JabRef is an open source bibliography reference manager. Simplifies reference m

Is this just a mistake by gradle -i or are the options really not passed in quotes?

    targetsWithOs("macos") {
        jpackageResources = layout.projectDirectory.dir("buildres").dir("macos")
        options.addAll(
            // Needs to be listed everyhwere, because of https://github.com/gradlex-org/java-module-packaging/issues/104
            "--description", "JabRef is an open source bibliography reference manager. Simplifies reference management and literature organization for academic researchers by leveraging BibTeX, native file format for LaTeX.",

[koppor]

W

With \" I get

/home/koppor/.gradle/jdks/amazon_com_inc_-25-amd64-linux.2/bin/jpackage --type app-image --dest /home/koppor/git-repositories/jabref/jabgui/build/packages/ubuntu-22.04 --module org.jabref --resource-dir /home/koppor/git-repositories/jabref/jabgui/build/tmp/jpackage/ubuntu-22.04/jpackage-resources --app-version 100.0.0 @/home/koppor/git-repositories/jabref/jabgui/build/tmp/jpackageUbuntu-22.04/args.txt --name JabRef --vendor JabRef --java-options --add-modules --java-options jdk.incubator.vector --java-options --enable-native-access=ai.djl.tokenizers,ai.djl.pytorch_engine,com.sun.jna,javafx.graphics,javafx.media,javafx.web,org.apache.lucene.core,jkeychain --java-options --add-opens --java-options java.base/java.nio=org.apache.pdfbox.io --java-options --add-opens --java-options java.base/jdk.internal.ref=org.apache.pdfbox.io --java-options -XX:+UnlockExperimentalVMOptions --java-options -XX:+UseCompactObjectHeaders --java-options -XX:+UseStringDeduplication --jlink-options --ignore-signing-information --jlink-options --compress --jlink-options zip-6 --jlink-options --no-header-files --jlink-options --no-man-pages --jlink-options --bind-services --jlink-options --generate-cds-archive --jlink-options --launcher --jlink-options JabRef=org.jabref/org.jabref.Launcher --add-modules jdk.incubator.vector --verbose

/home/koppor/.gradle/jdks/amazon_com_inc_-25-amd64-linux.2/bin/jpackage --type deb --app-version 100.0.0 --dest /home/koppor/git-repositories/jabref/jabgui/build/packages/ubuntu-22.04 --app-image /home/koppor/git-repositories/jabref/jabgui/build/packages/ubuntu-22.04/JabRef --description "JabRef is an open source bibliography reference manager. Simplifies reference management and literature organization for academic researchers by leveraging BibTeX, native file format for LaTeX." --license-file /home/koppor/git-repositories/jabref/jabgui/buildres/LICENSE_with_Privacy.md --icon /home/koppor/git-repositories/jabref/jabgui/buildres/linux/JabRef.png --file-associations /home/koppor/git-repositories/jabref/jabgui/buildres/linux/bibtexAssociations.properties --linux-menu-group Office; --linux-shortcut

---

Copy an pasting at the console, it seems to be an output issue only 😅

[jjohannes]

IIUC this is output from jlink. I don't think this plugin should modify that (feels out-of-scope).

In general, in my opinion, as user you should not care about escaping options if you use this (or any other) Gradle plugin. The plugin should care about escaping things if/where necessary. As far as I know, this works.

If this output is confusing, I think the first best step is not to show it if not needed, which is #105.

[koppor]

In general, in my opinion, as user you should not care about escaping options if you use this (or any other) Gradle plugin. The plugin should care about escaping things if/where necessary. As far as I know, this works.

I am copy and pasting the output - to create an MWE for JabRef/jabref#15180

The current MWE is https://github.com/koppor/java-minimum-desktop-app, but that works. Thus, I need to make it larger ^^.

[koppor]

; is also not escaped in the log output.