Skip to content

Add updatedAt time field to pull request queries #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
itsmylife wants to merge 2 commits into from
Closed

Add updatedAt time field to pull request queries #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79be970
add updatedAt to pull requests
itsmylife Oct 6, 2025
f16d964
test
itsmylife Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/models/pull_requests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,14 @@ const (
PullRequestCreatedAt
// PullRequestMergedAt is used when filtering when a Pull Request was merged
PullRequestMergedAt
// PullRequestUpdatedAt is used when filtering when a Pull Request was updated
PullRequestUpdatedAt
// PullRequestNone is used when the results are not filtered by time. Without any other filters, using this could easily cause an access token to be rate limited
PullRequestNone
)

func (d PullRequestTimeField) String() string {
return [...]string{"closed", "created", "merged"}[d]
return [...]string{"closed", "created", "merged", "updated"}[d]
}

// ListPullRequestsOptions are the available options when listing pull requests in a time range
Expand Down
1 change: 1 addition & 0 deletions src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export enum PullRequestTimeField {
ClosedAt,
CreatedAt,
MergedAt,
UpdatedAt,
None,
}

Expand Down
7 changes: 6 additions & 1 deletion tests/QueryEditor.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,10 @@ test('QueryEditor smoke test', async ({ panelEditPage, page }) => {
await panelEditPage.getByGrafanaSelector(components.QueryEditor.Repository.input).fill('grafana-github-datasource');

await panelEditPage.refreshPanel();
await expect(page.getByRole('cell', { name: 'grafana-github-datasource v1.5.7' })).toBeVisible();
try {
// Newer versions of table view uses gridcell instead of cell
await expect(page.getByRole('gridcell', { name: 'grafana-github-datasource v1.5.7' })).toBeVisible();
} catch (error) {
await expect(page.getByRole('cell', { name: 'grafana-github-datasource v1.5.7' })).toBeVisible();
}
});
Loading