mixin: update units for disk and networking panels#7
Merged
v-zhuravlev merged 2 commits intomasterfrom May 20, 2022
Merged
Conversation
https://prometheus.io/docs/prometheus/latest/querying/functions/#rate rate() calculates per-second average rate, therefore Bps units should be used for disks. In networking bandwidth throughput is usually measured in bits/s so units are changed accordingly. Signed-off-by: Vitaly Zhuravlev <zhuravlev.vitaly@gmail.com>
When appying rate() to seconds we have 'seconds per second' or fractions of the second, so actually it actually can be from 0 to 1. Also update intervalFactor to 1 for better rates. Signed-off-by: Vitaly Zhuravlev <zhuravlev.vitaly@gmail.com>
rgeyer
approved these changes
May 19, 2022
rgeyer
left a comment
There was a problem hiding this comment.
LGTM.
Couple things to consider.
- If you have access to the grafana fork, feel free to just make a feature branch here, rather than forking again to your own repo. If you don't have access, we can get that sorted.
- Has this already been changed in the upstream mixin? If not, can you also offer this as a PR upstream (if you haven't already, I didn't check).
Thanks!
Author
|
Thanks Ryan for reviewing,
|
Yup, sorry.. Too little coffee this morning, thanks!
Perfectly reasonable, thanks for being on top of it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change io time units from seconds to %util
When applying rate() to seconds we have 'seconds per second' or fractions of the second, so actually it actually can be from 0 to 1.