Plugin-e2e: Fix toggle viz selector for Grafana < 12.4.0#2350
Plugin-e2e: Fix toggle viz selector for Grafana < 12.4.0#2350hugohaggmark merged 1 commit intomainfrom
Conversation
Playwright test results
Troubleshooting404 when clicking on
|
There was a problem hiding this comment.
Pull request overview
This PR fixes version compatibility logic in the PanelEditPage class by updating version comparison operators from semver.lte (less than or equal) to semver.lt (less than) with version 12.4.0. The change ensures that the correct UI selectors are used when toggling and retrieving visualization names in Grafana 12.4.0 and later versions.
Key changes:
- Updated version comparison from
≤ 12.3.0to< 12.4.0for consistency - Applied the fix to both
setVisualization()andgetVisualizationName()methods
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🚀 PR was released in |
Fixes failing e2e tests in 12.3.1 and 12.4.0 of grafana. See the changes in grafana/plugin-tools#2350
What this PR does / why we need it:
This pull request updates version checks in the
PanelEditPageclass to ensure compatibility with Grafana versions 12.4.0 and above. The changes adjust the logic for selecting visualization-related UI elements based on the Grafana version.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/create-plugin@6.4.5-canary.2350.20292287699.0 npm install @grafana/plugin-e2e@3.0.5-canary.2350.20292287699.0 # or yarn add @grafana/create-plugin@6.4.5-canary.2350.20292287699.0 yarn add @grafana/plugin-e2e@3.0.5-canary.2350.20292287699.0