Skip to content

fix: pin golangci-lint and replace deprecated pointer helpers#517

Merged
NickAnge merged 2 commits intomainfrom
nikos/fix-golangci-lint
May 7, 2026
Merged

fix: pin golangci-lint and replace deprecated pointer helpers#517
NickAnge merged 2 commits intomainfrom
nikos/fix-golangci-lint

Conversation

@NickAnge
Copy link
Copy Markdown
Contributor

@NickAnge NickAnge commented May 7, 2026

Summary

  • Pin golangci-lint to v2.12.2 in CI to prevent silent upgrades from breaking lint
  • Replace deprecated github.String/Bool/Int/Int64 with github.Ptr

The lint job started failing because golangci-lint-action resolves latest at runtime. The v2.12.x release introduced Go 1.25's govet inline analyzer, which flags the old per-type pointer helpers.

Before

Screenshot 2026-05-07 at 16 51 03

after

Screenshot 2026-05-07 at 16 50 57

After that we can rebase and proceed with the renovate PRs

Test plan

  • go build ./... passes
  • go test ./internal/github/ passes (96 call sites changed, all tests green)

@NickAnge NickAnge requested a review from a team as a code owner May 7, 2026 14:46
@NickAnge NickAnge added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit 2c086a7 May 7, 2026
40 checks passed
@NickAnge NickAnge deleted the nikos/fix-golangci-lint branch May 7, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants