feat: Add bindings for exception handling (try/throw)#264
Merged
Conversation
spotandjake
changed the title
spotandjake
added
the
Api
ospencer
reviewed
Dec 21, 2025
Member
ospencer
left a comment
ospencer
left a comment
There was a problem hiding this comment.
Looking good overall! Because rethrow and delegation are a part of the legacy exception handling API, let's remove those.
Similar to how we do for data segments, let's make the API for Try.make a little more manageable by taking the tag/catch bodies together as a list of tuples or records, and accept a catch_all parameter that will append that last catch body, so it's not implicit.
spotandjake
force-pushed
the
spotandjake/try-catch-corrections
branch
from
9cb1e3d to
45614d6
Compare
Member
Author
|
I made those changes |
ospencer
approved these changes
Dec 28, 2025
Member
|
Just one comment update and this is good to go. |
ospencer
changed the title
Member
Author
|
I made that change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr is based off the work done in #197 and implements try catch.
This is up to date as of
v124&v125.Closes: #189, #197