Add a note on release-for-release matching with core Gramine#101
Add a note on release-for-release matching with core Gramine#101
Conversation
Additionally, update the notes on OS distros and Gramine versions for GCC and Scikit-learn. Signed-off-by: Dmitrii Kuvaiskii <dmitrii.kuvaiskii@intel.com>
mkow
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @dimakuv)
README.rst line 31 at r1 (raw file):
template, we recommend to remove the comments from your copies as they only add noise (see e.g. `Memcached <https://github.com/gramineproject/gramine/tree/master/CI-Examples/memcached>`__
I think this should be a relative URL? Otherwise it will always teleport to master.
dimakuv
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @mkow)
README.rst line 31 at r1 (raw file):
Previously, mkow (Michał Kowalczyk) wrote…
I think this should be a relative URL? Otherwise it will always teleport to
master.
Relative to what? We link from the examples repo to the gramine repo. So if you meant that, I don't think this is allowed in GitHub's RST?
mkow
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)
README.rst line 31 at r1 (raw file):
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
Relative to what? We link from the
examplesrepo to thegraminerepo. So if you meant that, I don't think this is allowed in GitHub's RST?
Ah, I missed that it changes the repo.
dimakuv
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required)
a discussion (no related file):
Blocking comment to first discuss it with all stakeholders (during Tuesday and Wednesday meetings)
kailun-qin
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
woju
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dimakuv)
|
During the Gramine Tuesday meeting, it was decided to keep the current Examples policy as-is, and postpone merging breaking changes such as #99 until after the next Gramine release is done. |
Additionally, update the notes on OS distros and Gramine versions for GCC and Scikit-learn.
This change is