pytorch: Set weights_only=False when loading models from a trusted source#115
Conversation
|
Continuation of this PR #114 |
kailun-qin
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: )
pytorch/pytorchexample.py line 7 at r1 (raw file):
import torch # Load the model from a file. This file needs to be obtained from a trusted
Pls rewrap to 100 chars.
mkow
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @sahason)
sahason
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ), "fixup! " found in commit messages' one-liners (waiting on @kailun-qin and @mkow)
pytorch/pytorchexample.py line 7 at r1 (raw file):
Previously, kailun-qin (Kailun Qin) wrote…
Pls rewrap to 100 chars.
Done.
kailun-qin
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel), "fixup! " found in commit messages' one-liners
mkow
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel), "fixup! " found in commit messages' one-liners
pytorch/pytorchexample.py line 8 at r2 (raw file):
# Load the model from a file. This file needs to be obtained from a trusted source, because it can # contain code, not only data. Note: For PyTorch 2.6 and later, unpickling with weights_only=True
Please leave Note: at a newline.
sahason
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ), "fixup! " found in commit messages' one-liners (waiting on @kailun-qin and @mkow)
pytorch/pytorchexample.py line 8 at r2 (raw file):
Previously, mkow (Michał Kowalczyk) wrote…
Please leave
Note:at a newline.
Done.
kailun-qin
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel), "fixup! " found in commit messages' one-liners (waiting on @mkow)
mkow
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required), "fixup! " found in commit messages' one-liners
…urce Signed-off-by: Sonali <sonali.saha@intel.com>
fb75895 to
9fdd89c
Compare
kailun-qin
left a comment
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)
Fixes #113
This change is