Open
Conversation
…a in ParamBuilder and ParameterProperty
|
@graniet Could you have a look? |
There was a problem hiding this comment.
Pull Request Overview
Updates the array item type from ParameterProperty to ParametersSchema, ensuring a unified schema representation.
- Change
ParameterProperty.itemsfield to useParametersSchema - Update
ParamBuilder’sitemsfield and method signature accordingly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/chat/mod.rs | Changed items field type to Option<Box<ParametersSchema>> |
| src/builder.rs | Updated items field type and items method signature in ParamBuilder |
Comments suppressed due to low confidence (4)
src/chat/mod.rs:93
- The doc comment above
itemsstill refers toparameter property, but the field now usesParametersSchema. Please update the comment to reflect the new schema type (e.g., "defines the schema for array items").
pub items: Option<Box<ParametersSchema>>,
src/builder.rs:677
- [nitpick] The field name
itemswith typeParametersSchemamay be ambiguous; consider renaming toitem_schemaoritems_schemato clarify it holds a schema rather than a property.
items: Option<Box<ParametersSchema>>,
src/builder.rs:706
- [nitpick] The parameter name
schema_propertyis generic; consider renaming toitem_schemato align with the field name and clarify its purpose.
pub fn items(mut self, schema_property: ParametersSchema) -> Self {
src/builder.rs:706
- There aren't tests covering the new
itemsmethod withParametersSchema; adding unit tests to ensure array parameters serialize correctly would improve coverage.
pub fn items(mut self, schema_property: ParametersSchema) -> Self {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it should be that way. With the Param it doesn't make any sense.