Skip to content

Remove all mathematical properties, use generic attributes instead#182

Merged
clue merged 1 commit intographp:masterfrom
clue-labs:no-math
Oct 9, 2019
Merged

Remove all mathematical properties, use generic attributes instead#182
clue merged 1 commit intographp:masterfrom
clue-labs:no-math

Conversation

@clue
Copy link
Member

@clue clue commented Oct 8, 2019

// old (applies to all properties: weight, balance, group etc.)
$vertex->setWeight(40);
assert($vertex->getWeight() === 40);

// new (already supported before)
$vertex->setAttribute('weight', 40);
assert($vertex->getAttribute('weight') === 40);

Among others, this resolves #114 (refs #131).
Builds on top of #181, #180 and #179.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use Attributes for all mathematical properties (weight, balance etc.)

1 participant