Mutations

[dOrgJelli]

A working prototype can be found here: https://github.com/dorgtech/the-graph-mutations-spec

[Jannis]

You'd think that it's pretty common and can be achieved with a transpiler and bundler, but I don't have much experience with that either. Bundling everything together into a single file at least should be no problem. Maybe ES2015 / ES6 is the better target nowadays?

Another question is the module system to use for exporting from the bundle (CommonJS, UMD, ...)?

@nenadjaja may have more experience with transpiling to older JS versions and bundling.

[Jannis]

https://www.tutorialspoint.com/babeljs/babeljs_transpile_es6_modules_to_es5.htm looks promising (webpack + babel with a single output file). I bet there are better guides out there though.

[dOrgJelli]

Thanks so much for this link, it was able to help me find a configuration that worked.

I've run into one last problem: building for a node environment and the browser requires different "target" types in the webpack config. I'm looking into solutions now, but I have a feeling we may end up needing to support something along the lines of:

resolvers:
  - kind: javascript/es5/node
    file: ./bundle-node/index.js
  - kind: javascript/es5/web
    file: ./bundle-web/index.js

[dOrgJelli]

This is the error I receive when trying to use a "node bundle" within the browser:

This is because...

When running the code in the browser, there is no builtin require function. If you want to flag a module as external in the browser, you have to provide some other way to load it (put a script tag, or integrate an AMD library like require.js). Otherwise this external module cannot be imported.

Taken from this response: liady/webpack-node-externals#17 (comment)

[Jannis]

I'm not sure why there even is a need to import anything. It's a bundle after all. I think I'll need some hands-on time with the bundling to figure something out.

[dOrgJelli]

Ahh that's very true, will investigate further.

[vercel]

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/graphprotocol/rfcs/blq8txh8i
✅ Preview: https://rfcs-git-fork-dorgtech-mutations.graphprotocol1.now.sh

[Jannis]

Alright, here we go!