make directives repeatable by default#652
Closed
nagliyvred wants to merge 1 commit intographql-java-kickstart:masterfrom
Closed
make directives repeatable by default#652nagliyvred wants to merge 1 commit intographql-java-kickstart:masterfrom
nagliyvred wants to merge 1 commit intographql-java-kickstart:masterfrom
Conversation
Collaborator
|
Can you check if #645 solves your problem? There was an overwhole of the directives code in GraphQL Java 18 |
Author
|
Thanks, will do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #615
Checklist
Description
Currently directive definitions are being ignored when parsing the schema and all directives are being assumed non-repeated. This is causing issues, for example, when using apollo-federation, as it prevents duplicate @key annotations on the federated entity.
While this PR doesn't fix the problem in it's entirety (for example, by parsing directives properly and validating them, as mentioned in #225 ) - it at least allows directive information not to get lost, by assuming all directives could be repeated.