Skip to content

Graceful shutdown for synchronous subscriptions #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KingDarBoja merged 4 commits into from
Jul 5, 2020
Merged

Graceful shutdown for synchronous subscriptions #99

KingDarBoja merged 4 commits into from
Jul 5, 2020

Conversation

@leszekhanusz
Copy link
Collaborator

@leszekhanusz leszekhanusz commented Jun 3, 2020

No description provided.

@coveralls
Copy link

coveralls commented Jun 3, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling f51dd70 on leszekhanusz:async_sync_graceful_shutdown into b6b7734 on graphql-python:master.

@KingDarBoja KingDarBoja added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change type: tests Adding missing or correcting existing tests labels Jun 14, 2020
@KingDarBoja KingDarBoja added this to the Version 3.0 milestone Jun 14, 2020
KingDarBoja
KingDarBoja reviewed Jun 20, 2020
View reviewed changes
@leszekhanusz leszekhanusz self-assigned this Jun 28, 2020
@KingDarBoja KingDarBoja added the status: waiting for author The PR author should address requested changes label Jun 29, 2020
@KingDarBoja
Copy link
Contributor

KingDarBoja commented Jul 5, 2020 •
edited
Loading

After merging this one, should be good to release a new beta version with latest changes.

cc @Cito

@leszekhanusz leszekhanusz force-pushed the async_sync_graceful_shutdown branch from 60df0f7 to 6220bff Compare July 5, 2020 17:10
@KingDarBoja KingDarBoja removed the status: waiting for author The PR author should address requested changes label Jul 5, 2020
@KingDarBoja KingDarBoja merged commit 140547d into graphql-python:master Jul 5, 2020
@leszekhanusz leszekhanusz deleted the async_sync_graceful_shutdown branch July 10, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@KingDarBoja KingDarBoja KingDarBoja approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@leszekhanusz leszekhanusz

Labels

type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change type: tests Adding missing or correcting existing tests

Projects

None yet

Milestone

Version 3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@leszekhanusz @coveralls @KingDarBoja