Open
Conversation
natebrennand
approved these changes
Feb 6, 2017
Contributor
natebrennand
left a comment
natebrennand
left a comment
There was a problem hiding this comment.
Can you add a comment explaining what that API call is doing?
I had to search around the library to figure out what those arguments did which is not ideal for comprehension.
Unrelated: maybe we've been going about this all wrong and gearcmd should push all updates to gearman-admin via the HTTP interface? Then we can remove the long running TCP connections between gearman-admin and gearcmd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds sending status as soon as job starts, so gearman admin can mark job as running