This repository was archived by the owner on Jan 8, 2025. It is now read-only.
Pass through desired value for scopeOnly in workaround#242
Merged
Conversation
…esired value was discarded, this adds the value back in.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
avatus
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that in the workaround for the
scopeOnlyprop the desired value was discarded. This PR adds that value back in with anullfallback to retain the previous functionality in the event no value is found.I believe that this workaround is in place until the
scopeOnlyprop values can be updated from boolean to string values as done elsewhere in #225.