feat: new form-builder#1437
Conversation
|
Preview is ready. |
It's a cool behavior that if a form has a condition, it's marked as "Hidden by condition," but if it's hidden, the fields become unclickable. Or maybe we should do this: Mark it with the "Visibility by condition" label, always, if there are any conditions. Классное поведение, что если в форме есть условие, то помечать его как "Hidden by condition", но если он hidden, то поля некликабельные становятся. А может сделаем так:
Почему? Я в редакторе собираю свою форму и пока что не собираюсь ее тестировать. Другими словами я хочу собрать структуру и хочу чтобы мне ничего не мешало. И только потом я перейду на вкладку Preview и потестирую |
Missed gap here. I assume it's due to the lack of a drag section. |
|
Can we change layout from this: 
To this? 
|
|
Is it possible to add functionality for inserting an existing config? Something like I insert my JSON and the form takes on the appearance of my config. 
In other words, you need not only a Copy schema, but also a Paste Schema. |
|
|
||
| #{$block} { | ||
| position: relative; | ||
| padding: 12px 14px; |
There was a problem hiding this comment.
why we dont use variables ?
| className: string; | ||
| } | ||
|
|
||
| const SectionChildrenDropZone: React.FC<SectionChildrenDropZoneProps> = ({ |
There was a problem hiding this comment.
create /components folder and create put all sub components into this folder, because this file is unnecessarily large
| display: grid; | ||
| grid-template-columns: minmax(0, 1fr) minmax(0, 1fr); | ||
| gap: 16px; | ||
| margin-top: 16px; |
| /> | ||
| ) : ( | ||
| <Text variant="body-2" color="hint"> | ||
| Add fields on the Visual tab to see the form here. |
There was a problem hiding this comment.
Let's add i18n later. It's not available right now. Everything is in English for now
There was a problem hiding this comment.
ok, but create issue for this
| onChange: (next: When | undefined) => void; | ||
| } | ||
|
|
||
| const parse = (when: When | undefined): {conditions: Condition[]; combinators: Combinator[]} => { |
There was a problem hiding this comment.
all utils func in utils file
NikitaCG
left a comment
NikitaCG
left a comment
There was a problem hiding this comment.
check my comments in all files please
4 participants
No description provided.