This repository was archived by the owner on Apr 11, 2025. It is now read-only.
Closed
Conversation
To make the onboarding experience of Mage2Docker Dolphin significantly better, we make composer projects the default instead of git repos. This may seem counter-intuitive, as most devs probably have a git repo, but for newbies, adding any additional configuration overhead kills uptake. BREAKING CHANGE: COMPOSER_PROJECT_ENABLED is now true by default. If you want it to be false (the old default) you will need to update your .env.
Co-authored-by: Nolan Arnold <nolan.arnold@gmail.com>
Co-authored-by: Nolan Arnold <nolan.arnold@gmail.com>
When the nginx.conf and the nginx.conf.sample of a stock Magento repo change, we automatically reload nginx to get the latest configuration
To mitigate any potential log4j vulnerability, we update to latest.
- fix: allow magento plugins during installation - test: change test to always build php image - chore: update setup.sh venia installation to the recommended setting
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
See #42
Fixes: #42
What is the new behavior?
See #42
Does this PR introduce a breaking change?
BREAKING CHANGES
This is non-breaking, but may become breaking in the future. Devs are encouraged to start using the Dolphin environment.