Reject requests with oversized chunk bodies#43
Merged
graygnuorg merged 1 commit intograygnuorg:masterfrom Jan 2, 2025
JeppW:client-error-on-oversized-chunk
Merged
Reject requests with oversized chunk bodies#43graygnuorg merged 1 commit intograygnuorg:masterfrom JeppW:client-error-on-oversized-chunk
graygnuorg merged 1 commit intograygnuorg:masterfrom
JeppW:client-error-on-oversized-chunk
Conversation
Owner
|
Thank you! |
This was referenced Apr 25, 2025
Merged
Merged
2 tasks
This was referenced May 5, 2025
Merged
Merged
This was referenced Jun 2, 2025
Merged
This was referenced Jun 18, 2025
Merged
Merged
This was referenced Dec 14, 2025
This was referenced Jan 16, 2026
This was referenced Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tightens the parsing of chunked HTTP requests by rejecting requests with oversized chunks. By oversized chunks, I mean chunks where the body exceeds the chunk size indicated in the chunk header. E.g.:
Currently, pound logs this error, but 'allows it' (i.e. forwards the entire chunk as-is and lets the backend deal with it).
This behaviour is incorrect, and it can cause problems with some backends. Specifically, some HTTP parsers accept any 2-byte sequence as the line terminator of a chunk body (not checking that it is in fact a CRLF sequence). In such cases, pound and the backend will interpret the chunk boundaries differently, which can potentially lead to a request smuggling vulnerability.