Skip to content

add delete functionality #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
h-bragg wants to merge 2 commits into from
Closed

add delete functionality #20

h-bragg wants to merge 2 commits into from

Conversation

@h-bragg
Copy link
Contributor

@h-bragg h-bragg commented Sep 28, 2015

  • Add delete functionality to the Client/Adapter

Resolves #19

@sjparkinson
Copy link
Contributor

sjparkinson commented Oct 2, 2015

Ok with #19 in mind, I'm actually going to be removing the purge method from ProducerInterface and making PurgableInterface.

It'd be best to do the same for this delete method, DeletableInterface.

Then ClientInterface would implement all four interfaces.

It'd also be good to have a MethodNotSupportedException available for any new adapters that don't support deleting of queues.

@h-bragg
Copy link
Contributor Author

h-bragg commented Oct 2, 2015

That make sense.

sjparkinson pushed a commit that referenced this pull request Oct 23, 2015
Seperate interfaces for deleting and purging.
ad3bd90 
* Add new MethodNotSupportedException
* Add basic tests for purge and delete on the Client
* Update the Makefile test targets to mount source code as a volume

Resolves #19, #20.
@sjparkinson sjparkinson mentioned this pull request Oct 23, 2015
Merged
@sjparkinson
Copy link
Contributor

sjparkinson commented Oct 23, 2015

Merged as part of #22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@h-bragg @sjparkinson