Allow release downloads to target forked repos#3
Open
enricoschaaf wants to merge 1 commit intostacked-guest-netfilter-supportfrom
Open
Allow release downloads to target forked repos#3enricoschaaf wants to merge 1 commit intostacked-guest-netfilter-supportfrom
enricoschaaf wants to merge 1 commit intostacked-guest-netfilter-supportfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This stacks on top of #2 and adds a single artifact-source override path so microsandbox can actually consume release artifacts from a fork instead of silently downloading upstream runtime binaries.
Without this, pointing Cargo at a forked git dependency is not enough:
scripts/install.shstill installs fromsuperradcompany/microsandboxcrates/microsandbox/build.rsstill downloads the prebuilt runtime bundle fromsuperradcompany/microsandboxmsb self updatestill checks upstream releasesWhat changed
MICROSANDBOX_GITHUB_REPOas anowner/repooverridescripts/install.shcrates/microsandbox/build.rscrates/utils/lib/lib.rscrates/cli/lib/commands/self_cmd.rsWhy this matters
The preceding stacked PR switches the runtime kernel source to your forked
libkrunfw. This PR makes the rest of the release download path follow the same fork so builds and installs are consistent.Validation
cargo test --manifest-path /tmp/microsandbox-enrico/crates/utils/Cargo.toml --libcargo test --manifest-path /tmp/microsandbox-enrico/crates/microsandbox/Cargo.toml --libcargo check --manifest-path /tmp/microsandbox-enrico/crates/cli/Cargo.toml