[CUSTOM-TEMPLATE] write test prove failing scenario#751
Closed
cgreene-st wants to merge 1 commit intogregberge:mainfrom
Closed
[CUSTOM-TEMPLATE] write test prove failing scenario#751cgreene-st wants to merge 1 commit intogregberge:mainfrom
cgreene-st wants to merge 1 commit intogregberge:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Owner
|
Closed as staled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cannot add comments to a custom template even though it looks like you should. The feature was added recently (#661) so it should work, but from my testing locally and this draft PR the test fails.
The scenario being, you want to add a comment to top of a custom template, to indicate that it's generated and not to edit. This is especially handy if you're adding the generated icons to source.
Test plan
NOTE: I've edited the snapshot to be what I expect, so the test is currently failing.