Allow CRLF at the start of multiline strings #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinheghan
requested changes
Aug 3, 2024
Member
robinheghan
left a comment
robinheghan
left a comment
There was a problem hiding this comment.
Good first attempt, but I think we can do better.
Also, please add your name to the CONTRIBUTORS file, if it isn't there already.
mbartlett21
force-pushed
the
multiline-string-crlf
branch
from
fe6da0e to
e004486
Compare
They are always encoded in the end result as just \n
mbartlett21
force-pushed
the
multiline-string-crlf
branch
from
e004486 to
4961a54
Compare
Member
|
Code formatting check fails. To apply correct code formatting, install |
Contributor
Author
|
@robinheghan previously dropped the newline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #254.
I also fixed another bug while I was at it. Gren was silently dropping the last newline if the string didn't end with a newline.