Merged
Conversation
ArsalaBangash
requested changes
Nov 4, 2020
Member
There was a problem hiding this comment.
Solid iteration
Great work! Here are some points I have:
- Realign the spacing in the customize practice card
How it was before
How it is now
- We use the kebab-case notation for directories, so let's rename assets//difficulty_icons to assets/difficulty-icons/
- I think CustomizePracticeCard or CustomizePractice would be a better name for the component since PracticeCard implies it's a card component where the practice occurs
This was referenced Nov 5, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vue-svg-loadervia webpack to import SVGs as Vue components. this also optimizes SVGs viasvgoin the build process, greatly improving load times of SVG assets. (will extend this to other SVG assets later)Preview