Bug fix compute facet owners#205
Open
amartinhuertas wants to merge 12 commits intomasterfrom
Open
Conversation
now depends on the strengthened version of compute_facet_owners in Gridap.jl
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #205 +/- ##
==========================================
- Coverage 84.56% 76.74% -7.83%
==========================================
Files 16 16
Lines 4238 4249 +11
==========================================
- Hits 3584 3261 -323
- Misses 654 988 +334
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amartinhuertas
commented
Apr 29, 2026
| end | ||
| facet_to_owner = map(local_views(model), cell_ids) do model, cell_ids | ||
| lid_to_gid = local_to_global(cell_ids) | ||
| select_nbor = Base.Fix2(select_nbor_with_max_gid, lid_to_gid) |
Member
Author
There was a problem hiding this comment.
Interesting ... I did not know that Fix2 method existed ... it is very handy here
Member
There was a problem hiding this comment.
Yes, I like the Fix structs a lot. In 1.13 they are introducing more of these, so you can have super performant closures.
…apDistributed.jl into bug_fix_compute_facet_owners
function FESpaces.compute_cell_bases_changes( ::ReferenceFEName, ::CoVariantPiolaMap, model::DistributedDiscreteModel, cell_reffe, cell_Jt ) in the case Dc==2 or polytope a simplex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.