Added HomogeneousTrialFESpace#67
Conversation
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 7 7
Lines 1338 1338
======================================
Misses 1338 1338 Continue to review full report at Codecov.
|
| end | ||
| end | ||
|
|
||
| function Base.setindex!( |
There was a problem hiding this comment.
This new method leads to type-piracy. Non of the types involved in the signature nor the function belongs to this package. We need the think a workaround.
Can you recall me how is the user API to save to vtk in GridapODEs ?
There was a problem hiding this comment.
Yes, this was also my concern.
In a driver with a sequence of output files per time step, one typically does something like:
paraview_collection(filename) do pvd
for (x,t) in xt
pvd[t] = createvtk(...)
end
endThe specialization is needed because for the distributed case createvtk returns a partitioned array of PVTKFile
| DistributedSingleFieldFESpace(spaces,f.gids,f.vector_type) | ||
| end | ||
|
|
||
| function FESpaces.TrialFESpace!(f::DistributedSingleFieldFESpace,fun) |
There was a problem hiding this comment.
Add some test that call these new functions
|
Hi @amartinhuertas @fverdugo , this PR contained some functions already merged in PR #74, but there are some missing tests that would be relevant to merge. |
4 participants
Hi @amartinhuertas @fverdugo , this function is needed from
GridapODEs