Improve cleanup of loop devices #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mika
requested changes
Jul 25, 2018
Member
mika
left a comment
mika
left a comment
There was a problem hiding this comment.
Also s/devmappings/device mappings/ in commit message
PS: thanks for working on this, I know what horrible yak shavery this is :(
Contributor
Author
|
This time you got the code update before I was able to comment.. :) |
jkirk
commented
Jul 26, 2018
jkirk
force-pushed
the
jkirk/kpartxworkaround
branch
from
4173daa to
77e7d77
Compare
Contributor
Author
|
After talking to @mika, I will squash my last commit. |
jkirk
force-pushed
the
jkirk/kpartxworkaround
branch
from
77e7d77 to
8a6b0ea
Compare
Contributor
Author
|
Rebased to current master and squashed the (now missing) commit, see: #112 (review) |
Member
jkirk
force-pushed
the
jkirk/kpartxworkaround
branch
from
8a6b0ea to
1166e53
Compare
Contributor
Author
|
Actually I did not "forget" to squash the commits. I wanted to keep the second one to make it visible that the issue was detected by spellsheck via the cool new Travis CI integration. But anyway, I squashed it now. |
jkirk
force-pushed
the
jkirk/kpartxworkaround
branch
from
1166e53 to
a421110
Compare
kpartx (sometimes) does not cleanup the loop devices when deleting the partition devmappings. This is a known bug, see Debian Bug #891077. This is change is a possible workaround for that issue. Now aborting grml-debootstrap is possible without leaving unneded loop devices behind.
jkirk
force-pushed
the
jkirk/kpartxworkaround
branch
from
a421110 to
33d0e7f
Compare
Member
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kpartx (sometimes) does not cleanup the loop devices when deleting the
partition devmappings. This is a known bug, see Debian Bug #891077.
This is change is a possible workaround for that issue.
Now aborting a grml-debootstrap is possible without leaving unneded loop
devices behind.