added review_reasons to the SDK for posting labels #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulina-positronix
approved these changes
Oct 10, 2023
mjvogelsong
reviewed
Oct 10, 2023
Contributor
mjvogelsong
left a comment
mjvogelsong
left a comment
There was a problem hiding this comment.
Let's bump the pyproject.toml minor version as well!
mjvogelsong
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serverside will soon strongly encourage that a
review_reasonis posted with a label (this value represents why the label was created). For now, all labels created by the SDK areCUSTOMER_INITIATEDso all we need to do is post this value whenever a SDK user creates a label.Blockers:
1. PR feedback2. The BE PR should be merged first, as otherwise the SDK will be posting data the server isn't capable of handling
3. Tests must pass (right now everything but detector improvement passes and I've run it a few times...).
4. Personally I would like to push a package update to pypi so our customers' SDK labels have the appropriate field in the POST rather than relying on the server to pick a sensible default.
5. BUMP TOML