Disable improvement test #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hon-sdk into disable_improvement_test
sunildkumar
reviewed
Oct 17, 2023
test/integration/test_groundlight.py
Outdated
| confident_iq = gl.ask_confident(detector=detector.id, image="test/assets/dog.jpeg", wait=180) | ||
| assert confident_iq.result.confidence > IQ_IMPROVEMENT_THRESHOLD | ||
| # temporarily disabled until the backend bugfix is deployed | ||
| # @pytest.mark.skipif(MISSING_PIL, reason="Needs pillow") # type: ignore |
Member
There was a problem hiding this comment.
Instead of commenting out you might just use @pytest.mark.skip(reason="Detector improvement is incredibly flaky") or something like that?
sunildkumar
approved these changes
Oct 17, 2023
Member
sunildkumar
left a comment
sunildkumar
left a comment
There was a problem hiding this comment.
I think it would be better to just use the decorator instead of commenting out.
brandon-wada
force-pushed
the
disable_improvement_test
branch
from
bb34069 to
3d041ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily disable tests dependent on code external to the SDK