-
Notifications
You must be signed in to change notification settings - Fork 6
Removed /python-sdk/ as the docs' base URL
#142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think you missed a few references to
Do a ctrl-f and make sure you get all of them since we're changing the base url |
mjvogelsong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please manually check the pages and links after you deploy!
| // Set the /<baseUrl>/ pathname under which your site is served | ||
| // For GitHub pages deployment, it is often '/<projectName>/' | ||
| baseUrl: "/python-sdk/", | ||
| baseUrl: "/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There might also be links on the public website or groundlight app that point to the old URL. Please look through the zuuul/reef code and change those as well. You can ask blake if you need changes on the public website.
The proper solution would be to add redirects from the old paths to the new paths, but we're hosting on github pages, so we'd have to do that client-side for each page (https://chat.openai.com/share/c2b2ef08-7577-41d6-890d-01a8ddab9517), which might be annoying. So, I'm okay if we just change the links on the other websites.
This reverts commit 918205b.
This reverts commit 918205b.
This is in part because we now have more than just SDK-related content on
code.groundlight.ai. In addition, this also allows us to just have the blog undercode.groundlight.ai/bloginstead ofcode.groundlight.ai/python-sdk/blog.