Skip to content

Conversation

@blaise-muhirwa
Copy link
Contributor

This is in part because we now have more than just SDK-related content on code.groundlight.ai. In addition, this also allows us to just have the blog under code.groundlight.ai/blog instead of code.groundlight.ai/python-sdk/blog.

@tyler-romero
Copy link
Contributor

I think you missed a few references to python-sdk, for example this link will be broken:

On the **submitting machine**, you will need to install the Groundlight Python SDK. Then you can submit image queries asynchronously using the `ask_async` interface (read the full documentation [here](pathname:///python-sdk/api-reference-docs/#groundlight.client.Groundlight.ask_async)). `ask_async` submits your query and returns as soon as the query is submitted. It does not wait for an answer to be available prior to returning to minimize the time your program spends interacting with Groundlight. As a result, the `ImageQuery` object `ask_async` returns lacks a `result` (the `result` field will be `None`). This is acceptable for this use case as the **submitting machine** is not interested in the result. Instead, the **submitting machine** just needs to communicate the `ImageQuery.id`s to the **retrieving machine** - this might be done via a database, a message queue, or some other mechanism. For this example, we assume you are using a database where you save the `ImageQuery.id` to it via `db.save(image_query.id)`.

Do a ctrl-f and make sure you get all of them since we're changing the base url

Copy link
Contributor

@mjvogelsong mjvogelsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please manually check the pages and links after you deploy!

// Set the /<baseUrl>/ pathname under which your site is served
// For GitHub pages deployment, it is often '/<projectName>/'
baseUrl: "/python-sdk/",
baseUrl: "/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might also be links on the public website or groundlight app that point to the old URL. Please look through the zuuul/reef code and change those as well. You can ask blake if you need changes on the public website.

The proper solution would be to add redirects from the old paths to the new paths, but we're hosting on github pages, so we'd have to do that client-side for each page (https://chat.openai.com/share/c2b2ef08-7577-41d6-890d-01a8ddab9517), which might be annoying. So, I'm okay if we just change the links on the other websites.

@blaise-muhirwa blaise-muhirwa merged commit 918205b into main Dec 13, 2023
blaise-muhirwa added a commit that referenced this pull request Dec 13, 2023
blaise-muhirwa added a commit that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants