Tests many versions of python #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-groundlight
approved these changes
Oct 25, 2022
Contributor
michael-groundlight
left a comment
michael-groundlight
left a comment
There was a problem hiding this comment.
It's nice to have the version matrix!
UserGuide.md
Outdated
|
|
||
| ### Using Groundlight SDK on Ubuntu 18.04 | ||
|
|
||
| Ubuntu 18.04 still uses python 3.6 by default, which is end-of-life. We recommend python 3.8, as follows: |
Contributor
There was a problem hiding this comment.
Is the reason for recommending 3.8 that we think 3.9 and 3.10 might not be supported by other python libraries the customer is using? Or because apt doesn't support 3.9 / 3.10?
Member
Author
There was a problem hiding this comment.
The latter. Ubuntu 18 offers 3.6, 3.7, and 3.8 without adding external package archives.
UserGuide.md
Outdated
Comment on lines
55
to
59
| sudo apt-get update | ||
| sudo apt-get install -y python3.8 python3.8-distutils wget | ||
| wget https://bootstrap.pypa.io/get-pip.py | ||
| python3.8 get-pip.py | ||
| python3.8 -m pip install groundlight |
Contributor
There was a problem hiding this comment.
Should we make this a bash script?
Member
Author
There was a problem hiding this comment.
Maybe?
curl -sf -L https://groundlight.ai/install-python-sdk.sh | sudo sh
I feel like that kind of thing triggers security fears in people though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updating the UserGuide on how to install for Ubuntu 18.04