Deprecate /device-api/posichecks endpoint #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjvogelsong
approved these changes
Feb 15, 2024
Contributor
mjvogelsong
left a comment
mjvogelsong
left a comment
There was a problem hiding this comment.
Great, this is cleaner!
Also, I would recommend bumping the pyproject.toml version to 0.13.4.
Comment on lines
-251
to
-252
| @RequestsRetryDecorator() | ||
| def submit_image_query_with_inspection( # noqa: PLR0913 # pylint: disable=too-many-arguments |
Contributor
There was a problem hiding this comment.
Yay! I like when we get to delete code!
mjvogelsong
reviewed
Feb 15, 2024
package.json
Outdated
Comment on lines
4
to
6
| "@openapitools/openapi-generator-cli": "^2.7.0", | ||
| "rehype-katex": "^7.0.0", | ||
| "remark-math": "^6.0.0" |
Contributor
There was a problem hiding this comment.
Oh, also, why were these added? Seems irrelevant to this PR.
blaise-muhirwa
approved these changes
Feb 15, 2024
Contributor
blaise-muhirwa
left a comment
blaise-muhirwa
left a comment
There was a problem hiding this comment.
Looks good to me!
Member
|
I think this should get lumped into a v0.14.0 release - it's a relatively big change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We need to deprecate the old /device-api/posichecks in favor of /device-api/v1/image-queries. Camilo has completed his changes to support this and they have been deployed to prod.
Changes in this PR
spec/public-api.yamlhas been updated to supportinspection_idsubmit_image_query_with_inspectionhas been removed fromsrc/groundlight/internalapi.pybecauseinspection_idis now supported in the public API.Jira: https://positronixcorp.atlassian.net/browse/PK-1783