Faster HTTP timeout #168
Faster HTTP timeout #168
Conversation
…s a networking error.
robotrapta
force-pushed
the
faster-timeout
branch
from
5b87d1e to
a0586f8
Compare
brandon-wada
left a comment
brandon-wada
left a comment
There was a problem hiding this comment.
LGTM. it feels like it would be nice to somehow change the default _request_timeout in the detectors_api and image_queries_api so we don't have to invoke the timeout parameter inside client.py, but thats more aesthetics than function
|
I thought about exposing an environment variable to set the default timeout. But it adds complexity, and I think it would be used extremely rarely. The standard TCP/IP timeout values were set in the 1980s or so, when networks were extremely slow and unreliable, so it made sense to keep trying for 30 seconds to reach a remote server. Today, that's insane, but many systems still use those classic timeout values. Even at 5 seconds, the only place I can imagine a connection succeeding after longer than that would be on an airplane with sketchy connectivity, for example. It's conceivable, but crazy rare. So I don't think it's worth the complexity to even expose it. |
Fixes #167 - it could take over 8 minutes for an API connection to timeout if nothing's listening.