-
Notifications
You must be signed in to change notification settings - Fork 6
Basic python SDK #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
romerocesar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
normally I consider README like a dev guide and some other doc as a user guide. right now usage instructions are split between examples and readme
also, I prefer not to push lockfiles to libraries since they quickly result in the dev environment being different than the consuming env with minor updates to any dependency which we actually want to be able to test against and catch issues sooner than later
for the near future: it would be great to add notebooks with examples that can actually run out of the box
| @@ -0,0 +1,33 @@ | |||
| [tool.poetry] | |||
| name = "groundlight" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we may want to push a placeholder to pypi.org to sit on this since there are no namespaces in pypi and packages are identified only by name and number (not URL) so names have to basically be globally unique
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that's a good idea https://positronixcorp.atlassian.net/jira/software/projects/PK/boards/6?selectedIssue=PK-280
robotrapta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very exciting!
I moved a few things around to make the distinction clearer. Not perfect, but better.
Agreed, I've removed poetry.lock and added an entry in gitignore.
Added it to the TODO list. |
See the README.md and Examples for details. I list several known TODOs at the bottom.
Everything under
generated/is autogenerated using openapi-generator, which usesspec/public-api.yaml.