Skips some tests that are currently causing problems for internal users #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon-wada
commented
Oct 15, 2024
Collaborator
Author
brandon-wada
left a comment
brandon-wada
left a comment
There was a problem hiding this comment.
SDK tests run in 3 min 22 seconds on my local machine after these changes. I've made a ticket to organize the tests better so we can call only a certain subset of tests based on who is making the call.
| from groundlight_openapi_client.exceptions import NotFoundException | ||
|
|
||
|
|
||
| @pytest.mark.skip(reason="This is an expensive test, reset may take some time") |
Collaborator
Author
There was a problem hiding this comment.
This is likely the source of much of our current SDK test time
| raise Exception("Failed to reset detector") | ||
|
|
||
|
|
||
| @pytest.mark.skip(reason="This test does not work with strong 0 shot models, enabled by default based on your account") |
Collaborator
Author
There was a problem hiding this comment.
This no longer works for internal users because GLAVA is so confident
| assert count_iq.result.count is not None | ||
|
|
||
|
|
||
| @pytest.mark.skip( |
Collaborator
Author
There was a problem hiding this comment.
The SDK got ahead of reef, and what we've enabled for internal users, so this test is actually causing issues during development
…/python-sdk into sdk_tests_for_internal_users
tyler-romero
approved these changes
Oct 15, 2024
Contributor
tyler-romero
left a comment
tyler-romero
left a comment
There was a problem hiding this comment.
LGTM! Thanks Brandon!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.