Multiclass label support #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-romero
reviewed
Dec 4, 2024
| return label | ||
|
|
||
|
|
||
| def convert_display_label_to_internal( |
tyler-romero
reviewed
Dec 4, 2024
src/groundlight/client.py
Outdated
| **Example usage**:: | ||
| gl = Groundlight() | ||
| gl = ExperimentalApi() |
Contributor
There was a problem hiding this comment.
Why does this need to be ExperimentalAPI()?
Collaborator
Author
There was a problem hiding this comment.
Copy paste, my greatest power and greatest weakness
tyler-romero
approved these changes
Dec 4, 2024
Contributor
tyler-romero
left a comment
tyler-romero
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding those new tests too
added 2 commits
December 4, 2024 01:22
…hon-sdk into multiclass_label_support
Contributor
|
I'm seeing backend errors that I believe are related to this PR. Specifically, submitting counting labels triggers count-detector training. But our create_count_detector sdk method doesnt allow specifying what the object to be counted is. This bad specification of count detectors causes errors during training. |
srnangi
reviewed
Dec 5, 2024
| gl_experimental.add_label(iq1, "cherry") | ||
| iq1 = gl_experimental.get_image_query(iq1.id) | ||
| assert iq1.result.label == "cherry" | ||
| # You can submit the index of the class as well |
Contributor
There was a problem hiding this comment.
Ohh, I see that we can use class index in labels. Should we add this to function description for add_label too?
…hon-sdk into multiclass_label_support
…des, most data is valid now
…hon-sdk into multiclass_label_support
…hon-sdk into multiclass_label_support
…hon-sdk into multiclass_label_support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests and labeling support for multiclass detectors