Pil image support. Default WAIT #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robotrapta
changed the title
obj-imp
reviewed
Apr 2, 2023
tyler-romero
reviewed
Apr 2, 2023
src/groundlight/client.py
Outdated
| def submit_image_query( | ||
| self, | ||
| detector: Union[Detector, str], | ||
| image: Union[str, bytes, BytesIO, BufferedReader, np.ndarray], |
Contributor
There was a problem hiding this comment.
nit: add Image.Image to the supported input types
tyler-romero
approved these changes
Apr 2, 2023
Contributor
tyler-romero
left a comment
tyler-romero
left a comment
There was a problem hiding this comment.
LGTM, just a couple nits
Member
Author
Unfortunately, I think the answer is that it "almost works". I think what will happen is that we will accept the image, but the colors will be wrong because OpenCV uses BGR order for color-channel, but we expect RGB. This is certainly not awesome. If we're getting an image as a numpy array, it's very likely it came from OpenCV. Maybe we should require images to be BGR. That change would be backwards incompatible though. Filed #34 to track this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now submit imagequeries with PIL images. But obviously only if PIL is installed. Fixes #22
Also you can set
gl.DEFAULT_WAITwhich overrides the default 30 for all submit-image-query calls.