Patience time #97
Closed
Patience time #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon-wada
force-pushed
the
patience_time
branch
from
86a7303 to
397ec9e
Compare
Collaborator
Author
|
This isn't quite what we laid out in the planning document, I was struggling a bit because it seemed like ask_ml and ask_confident would devolve into each other, each being a limiting case of the other. In this version, the goal is to make the three different ask_* functions friendly user entry points. submit_image_query remains the workhorse submission function with the full feature set, but we can encourage use of the ask_* functions, none of which require knowledge of both wait_time and patience_time. |
Contributor
|
I think #99 is taking the place of this PR, so I'll close this one. Feel free to re-open if I'm mistaken! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pass at implementing wait and patience time in the SDK according to the design doc.