Skip to content

enh: change output_volume based on post_merge_function#177

Merged
sylvchev merged 7 commits intogrowingnet:mainfrom
stelladk:volume
Dec 8, 2025
Merged

enh: change output_volume based on post_merge_function#177
sylvchev merged 7 commits intogrowingnet:mainfrom
stelladk:volume

Conversation

@stelladk
Copy link
Copy Markdown
Collaborator

@stelladk stelladk commented Nov 26, 2025

  • Change the output_volume based on potential resizing in the post_merge_function
  • Allow arbitrary reshaping of the output without affecting the post-activity (reshape_function attribute). This change handles flattening when growing Conv -> Lin.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
unittests 94.55% <100.00%> (-0.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/gromo/modules/conv2d_growing_module.py 90.59% <100.00%> (+0.16%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stelladk stelladk marked this pull request as ready for review December 1, 2025 10:34
@TheoRudkiewicz
Copy link
Copy Markdown
Collaborator

Sorry, but I don't understand this PR. So I can't review it.

@stelladk stelladk marked this pull request as draft December 1, 2025 16:53
@stelladk stelladk marked this pull request as ready for review December 3, 2025 13:33
Copy link
Copy Markdown
Collaborator

@sylvchev sylvchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stelladk

@sylvchev sylvchev merged commit d7b0f98 into growingnet:main Dec 8, 2025
6 of 7 checks passed
@stelladk stelladk deleted the volume branch December 9, 2025 13:14
@stelladk stelladk mentioned this pull request Mar 25, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants