ci(ruff-check.yaml): Disable ruff outside of src, tests and examples and make it blocking#207
Merged
TheoRudkiewicz merged 4 commits intogrowingnet:mainfrom Mar 2, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ci: Disable ruff formatting
Collaborator
|
This is partly done in #200 but we can merge it earlier |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CI linting so Ruff becomes a blocking check while limiting what paths are linted, and documents the change in the changelog.
Changes:
- Make the Ruff workflow blocking (
continue-on-error: false). - Restrict
ruff checktosrc,tests, andexamples, and disable the Ruff formatting check step. - Add an entry to the “What’s new” page noting the CI change.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
docs/source/whats_new.rst |
Adds a changelog bullet about Ruff CI scope/blocking behavior. |
.github/workflows/ruff-check.yml |
Makes Ruff linting blocking and narrows the lint target paths; comments out formatting check. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheoRudkiewicz
changed the title
ruff-check.yaml): Disable ruff outside of src and make it blockingruff-check.yaml): Disable ruff outside of src, tests and examples and make it blocking
sylvchev
approved these changes
Mar 2, 2026
Collaborator
sylvchev
left a comment
sylvchev
left a comment
There was a problem hiding this comment.
Thank @TheoRudkiewicz we finally have an all green CI!
sylvchev
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As there is no more ruff issues in
src, let's make is blocking.