Skip to content

!feat: Handle FO loss decrease when ignore_singular_values=True#241

Draft
TheoRudkiewicz wants to merge 1 commit intogrowingnet:mainfrom
TheoRudkiewicz:ignore_singular_values
Draft

!feat: Handle FO loss decrease when ignore_singular_values=True#241
TheoRudkiewicz wants to merge 1 commit intogrowingnet:mainfrom
TheoRudkiewicz:ignore_singular_values

Conversation

@TheoRudkiewicz
Copy link
Copy Markdown
Collaborator

Fix #217

@TheoRudkiewicz TheoRudkiewicz self-assigned this Apr 19, 2026
@TheoRudkiewicz TheoRudkiewicz marked this pull request as draft April 19, 2026 22:10
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 19, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/gromo/modules/growing_module.py 0.00% 1 Missing and 1 partial ⚠️
Flag Coverage Δ
unittests 94.33% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/gromo/modules/growing_module.py 96.70% <0.00%> (-0.25%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Incorrect first_order_improvement when ignore_singular_values=True

1 participant