Conversation
* rm duplicates added rsync * added bzip, pw10 theme ownership, and consistant ADD over COPY * adding ownership and history plugin as well as rc files * codespace font setting * Coder (growlf#6) * moar promptiness * more compatible with lesser fonting * add user to docker group * corrected docker lib reference * added dockerinfo to tasks * better separation of build env * Testing with badges and adding notes * Testing with badges and adding notes * changed workflow names * changed from app to dev container name * fixed indent filure * indenting * versioning test * removed bad version test * added Docker test tasks * added docker test tasks * added example bash script to basic-test network * Added test_net and docs * added ansible tool
Group #1 added tools
Collaborator
|
Pull requests should contain useful information about the reasoning behind the changes for the repository maintainer to enable them to prioritize PRs. This is part of the collaborative workflow. |
growlf
approved these changes
Feb 25, 2024
Owner
growlf
left a comment
growlf
left a comment
There was a problem hiding this comment.
Well done - thank you for your improvements!
| && apt-get autoremove -y \ | ||
| && apt-get clean -y \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
| screen tmux \ |
| - /var/run/docker.sock:/var/run/docker.sock | ||
| - ${HOME}/.gitconfig:/home/ubuntu/.gitconfig | ||
| - ${HOME}/.ssh:/home/ubuntu/.ssh | ||
| - .:/src |
Owner
There was a problem hiding this comment.
Generally better practice to use the shell variable and not globbing which might not act as expected.
| pyfiglet==1.0.2 | ||
| speedtest-cli==2.1.3 | ||
| urllib3==2.1.0 | ||
| ansible==9.2.0 |
Owner
There was a problem hiding this comment.
Good catch!! I had this in my develop branch - but this is a very subtle failure in the original code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.